cRPG updater - Temporary replacement of cRPG Launcher

[Gurgumul]

Elio & Switchtense give more dev feedback in one thread than the entire Burro Battalion in all of their threads and videos.

[Elio]

@Switchtense

(click to show/hide)

That could be a way.

But instead of updating from an empty folder it could be faster to copy the current module that require privileges to write on local or temp directory.

But having to coping manually is a bit rudimentary.

There is also possibility to launch the updater from your GUI as administrator.

• Check if Warband path is writable
• If not writable launch crpg_update as administrator

This should prompt privileges after clicking on "Update", except if compiler add privileges requirement for the whole app.

[Switchtense]

@Switchtense

(click to show/hide)

That could be a way.

But instead of updating from an empty folder it could be faster to copy the current module that require privileges to write on local or temp directory.

But having to coping manually is a bit rudimentary.

There is also possibility to launch the updater from your GUI as administrator.

• Check if Warband path is writable
• If not writable launch crpg_update as administrator

This should prompt privileges after clicking on "Update", except if compiler add privileges requirement for the whole app.

Is your script now able to create the cRPG folder?

Cause currently the GUI needs admin rights to do so. (If the Warband folder is inside the programs-folder)

Your update does not need admin rights at all.

My problem at the moment is that I can tell whether the application is run as an admin, but it is difficult to check whether, as a standard user, it is possible to write into the Warband folder, without throwing an UnauthorizedAccessException (Or whichever is used when trying to do something you need admin for)
I cannto seem to find a reliable method which lets you know whether you need admin for whatever you are about to do.

I could only check what folder the user selected, if it contains "programs" I can ask for an alternative path. But that is even more quick & dirty than it already is. A lot more than I'd like.


If the app is being run as an admin, I can just proceed whatever happens, but the case of being a standard user is giving me a headache.

[Switchtense]

Actually, I can just go ahead and start creating the cRPG folder.

If the user does not have the rights to do so, I can just catch the exception and ask the user to choose an alternative path.

Then the same game. I try to create the folder, if it does not work, ask for another path again. (With a message saying what the problem is obviously)

Will properly test tomorrow. Gotta take admin off my windows account to properly test it. Cannot be bothered to do that tonight.

[Elio]

Is your script now able to create the cRPG folder?

I only update existing module that contains at least version.txt.

But of course I could implement the same thing you made to create/install cRPG if necessary.

(click to show/hide)

but it is difficult to check whether, as a standard user, it is possible to write into the Warband folder, without throwing an UnauthorizedAccessException (Or whichever is used when trying to do something you need admin for)

But you can catch it?

For example on my code I catch PermissionError (errno EACCES/EPERM), a child of OSError class.
But I don't handle it for now, it just throws it away at closing with sys.exit(exc_value)

By the way you should be able to know whenever the update exit successfully or not, It returns 0 if done as expected, otherwise a type string (TBC) of the exceptions.

I don't have time to work on it until this week-end, if you want feel free to try a solution on your side.

visitors can't see pics , please register or login

[Switchtense]

Yes, I know whether the update finished successfully.

And I changed it just now.
I now just try to create the folder.
If the user is an admin, it is all good and I just start your updater and all good.

If the user is no admin, the exception is thrown when trying to create the folder.
I catch the exception and ask the user for a different path to install the game to. (User can also say 'no', then the update cancels)
If the program can create the folder in the chosen path without requiring admin, all good. Update starts and perfect.

If the new path needs admin to create a folder again, same thing as before. Thrown exception is caught. Does user want a different path? No - Cancel, Yes - Try to create folder.
(Used recursion on this one)


Will test it tomorrow

[andreakarasho]

Nice app!

If i had time i would write a c# app to update

[WITCHCRAFT]

Fantastic work Elio and Switch!

You have saved many people that would just go "eh, it won't work" and play a different game. 

[Switchtense]

Fantastic work Elio and Switch!

You have saved many people that would just go "eh, it won't work" and play a different game. 

So basically we ruined many people's lives?

[WITCHCRAFT]

they were going to waste hours in front of their computer anyway, so

[Butan]

So basically we ruined many people's lives?

Only a few, still worth it!

[Jambi]

Eh, it won't work.

[Switchtense]

Eh, it won't work.

Thanks to the very detailed explanation you provided I was able to instantly find the problem and fix it. Try again, just make sure to turn your computer off and on again first.

[_RXN_]

Eh, it won't work.

Download cRPG update 1.02, unzip, launch crpgUpdaterGUI.exe, enter Warband path, update, close, run C-RPG launcher, play.

[Jepekula]

I think someone here has missed a joke.

(click to show/hide)

Fantastic work Elio and Switch!

You have saved many people that would just go "eh, it won't work" and play a different game.